Ensure version tag matches deployed version#821
Open
Javex wants to merge 4 commits intonextcloud:mainfrom
Open
Ensure version tag matches deployed version#821Javex wants to merge 4 commits intonextcloud:mainfrom
Javex wants to merge 4 commits intonextcloud:mainfrom
Conversation
When overriding `image.tag` the version label should also show the correct version. Previously, the label would always be AppVersion, even if the user had provided a different image tag (thus deploying a different Nextcloud version). With this change, the version is always first derived from the image tag and only from AppVersion if not tag was provided. For the "nextcloud.image" helper this was already the case, now the "version" label on all resources also does this. Signed-off-by: Florian Ruechel <code@inexplicity.de>
Collaborator
|
You drop th support for |
Signed-off-by: Florian Ruechel <code@inexplicity.de>
Javex
force-pushed
the
app-version-image-tag
branch
from
b9ebfc6 to
e9a214a
Compare
Author
|
@wrenix Good catch, thanks! Fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
When overriding
image.tagthe version label should also show the correct version. Previously, the label would always be AppVersion, even if the user had provided a different image tag (thus deploying a different Nextcloud version).With this change, the version is always first derived from the image tag and only from AppVersion if not tag was provided. For the "nextcloud.image" helper this was already the case, now the "version" label on all resources also does this.
Benefits
Version label always represents deployed image tag.
Possible drawbacks
If user's have specified a different version through the image tag then all of their resources' version label will change, causing a re-deployment. However, no difference in functionality should be observed and no user action is needed. That is, this is a backwards-compatible change.
Applicable issues
N/A
Additional information
Checklist
Chart.yamlaccording to semver.